Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Scopes #186

Closed
voicecode-bv opened this issue Jul 11, 2023 · 3 comments · Fixed by #187
Closed

[Feature request] Scopes #186

voicecode-bv opened this issue Jul 11, 2023 · 3 comments · Fixed by #187

Comments

@voicecode-bv
Copy link

voicecode-bv commented Jul 11, 2023

Hi there!

I noticed when working on one of my projects, that we could really benefit from having some scopes to the subscription model.

There are already some methods to define active, onTrial or onGracePeriod subscriptions, but as far as I have seen, there are no scopes for this. We would use an scopeActive scope for example, to fetch all active yearly subscriptions, so we can reset some monthly restrictions for the subscription's owner.

Is this something you're willing to help out with?

Naoray added a commit to Naoray/laravel-cashier-mollie that referenced this issue Jul 17, 2023
@Naoray
Copy link
Collaborator

Naoray commented Jul 17, 2023

Hello @voicecode-bv,

I appreciate your suggestion. I have taken the initiative to create a pull request (PR #187) that includes specific scopes for each boolean method found in the Subscription class.

I hope you are satisfied with the changes made!

@voicecode-bv
Copy link
Author

You've made my day! Thanks for this, really appreciate it!

@Naoray
Copy link
Collaborator

Naoray commented Jul 18, 2023

@voicecode-bv released in the lastest version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants