fixed issue #1233 #1296
Closed
fixed issue #1233 #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks. This will need tests though |
|
It did pass the unit tests for duration/. I can write more tests there if that's helpful |
|
@CristiMacovei Yeah, so in general if you fix an issue, you write a test that would fail without your change and then make it pass with your code. That way, if someone make a change that breaks your fix, then they'll right away. |
|
Yeah, I'll get to that and I'll open another PR. Sorry, didn't know I was supposed to do that first |
|
It's ok for the test to be in the same PR, even if it only fails without your other code changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a couple of changes to the code to solve issue #1233