Skip to content

Commit

Permalink
chore: remove unnecessary tests and fix test warnings (#236)
Browse files Browse the repository at this point in the history
Remove tests based on throwing TypeError. They were the cause of the
errors/warnings in IntelliJ and test the PHP type system rather than
Momento validation code. A momento function argument that isn't nullable
throws a TypeError when given null.

Remove tests based on casting null to string. (string)null is equal to
empty string, so those tests were redundant.

Change some of the existing TypeError tests to test empty strings
instead of nulls to test the validation logic for those fields.

Fix two ttl assertions that weren't checking the returned values.

Fix misc. warnings, including unused variables, and extra arguments from
copy/paste errors.
  • Loading branch information
nand4011 authored Oct 19, 2024
1 parent 702897c commit 8d41a6e
Showing 1 changed file with 60 additions and 487 deletions.
Loading

0 comments on commit 8d41a6e

Please sign in to comment.