Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename items to elements #120

Merged
merged 1 commit into from
Mar 28, 2023
Merged

fix: rename items to elements #120

merged 1 commit into from
Mar 28, 2023

Conversation

pgautier404
Copy link
Collaborator

This commit renames items to elements for dictionarySetFields to conform to naming conventions. It also removes an unused validator function.

krispraws
krispraws previously approved these changes Mar 27, 2023
Copy link

@krispraws krispraws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I'd let someone with more knowledge of this SDK give the final approval.

@pgautier404 pgautier404 requested a review from rishtigupta March 27, 2023 23:16
@pgautier404 pgautier404 merged commit 7efdf3d into main Mar 28, 2023
@pgautier404 pgautier404 deleted the rename-items-to-elements branch March 28, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants