feat: replace authToken with authProvider #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malandis
reviewed
Oct 12, 2022
Comment on lines
+24
to
+25
| $defaultTtlSeconds, | ||
| $dataClientOperationTimeoutMs |
There was a problem hiding this comment.
Is there a standard TimeSpan-like construct in PHP? Would be strong to avoid hoisting number conversions on the users
There was a problem hiding this comment.
I'm +1 to this idea, but if such a thing exists in PHP, we can handle it as a separate ticket/PR.
cprice404
approved these changes
Oct 13, 2022
| @@ -0,0 +1,27 @@ | |||
| <?php | |||
There was a problem hiding this comment.
so i take it that in modern PHP you don't need a closing tag for this anymore? TIL
Comment on lines
+24
to
+25
| $defaultTtlSeconds, | ||
| $dataClientOperationTimeoutMs |
There was a problem hiding this comment.
I'm +1 to this idea, but if such a thing exists in PHP, we can handle it as a separate ticket/PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.