Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct broken InRegion configuration #161

Closed
wants to merge 1 commit into from
Closed

fix: Correct broken InRegion configuration #161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Config/Configurations/InRegion.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class InRegion extends Configuration
* improvements we identify for default configurations.
*
* @param ILoggerFactory|null $loggerFactory
* @return Laptop
* @return InRegion
*/
public static function latest(?ILoggerFactory $loggerFactory = null): Laptop
{
Expand All @@ -33,13 +33,13 @@ public static function latest(?ILoggerFactory $loggerFactory = null): Laptop
* in future releases of the SDK.
*
* @param ILoggerFactory|null $loggerFactory
* @return Laptop
* @return InRegion
*/
public static function v1(?ILoggerFactory $loggerFactory = null): Laptop
public static function v1(?ILoggerFactory $loggerFactory = null): InRegion
{
$loggerFactory = $loggerFactory ?? new NullLoggerFactory();
$grpcConfig = new StaticGrpcConfiguration(1100);
$transportStrategy = new StaticTransportStrategy(null, $grpcConfig, $loggerFactory, self::$maxIdleMillis);
return new Laptop($loggerFactory, $transportStrategy);
$transportStrategy = new StaticTransportStrategy($grpcConfig, $loggerFactory, self::$maxIdleMillis);
return new self($loggerFactory, $transportStrategy);
}
}