Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve resource exhausted error message #247

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Conversation

anitarua
Copy link
Contributor

@anitarua anitarua commented Nov 5, 2024

Closes https://github.com/momentohq/dev-eco-issue-tracker/issues/1042

When a RESOURCE_EXHAUSTED error is received, we now parse the err metadata in order to report the cause in the message wrapper. If the metadata is not available, we try to use string matching on the error details.

@anitarua anitarua marked this pull request as ready for review November 5, 2024 19:20
@anitarua anitarua requested a review from a team November 5, 2024 19:20
Copy link
Contributor

@rishtigupta rishtigupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anitarua anitarua merged commit c29417e into main Nov 5, 2024
9 checks passed
@anitarua anitarua deleted the resource-exhausted branch November 5, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants