Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: convert deadline secs to expected gRPC value in constructor #34

Merged
merged 1 commit into from
Oct 21, 2022
Merged

chore: convert deadline secs to expected gRPC value in constructor #34

merged 1 commit into from
Oct 21, 2022

Conversation

pgautier404
Copy link
Collaborator

No description provided.

malandis
malandis approved these changes Oct 21, 2022
View reviewed changes
Copy link
Collaborator

@malandis malandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks cleaner and easier to maintain

@pgautier404 pgautier404 merged commit 38152f2 into main Oct 21, 2022
@malandis malandis deleted the fix-deadline-calculation branch November 1, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malandis malandis malandis approved these changes

@poppoerika poppoerika Awaiting requested review from poppoerika

@cprice404 cprice404 Awaiting requested review from cprice404

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pgautier404 @malandis