Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update examples to use latest release and other small updates #124

Merged
merged 4 commits into from
Jan 8, 2024

Conversation

anitarua
Copy link
Collaborator

@anitarua anitarua commented Jan 6, 2024

Addresses the last two tasks of https://github.com/momentohq/dev-eco-issue-tracker/issues/604

  • Updates all examples to use the latest release (0.4.0)
  • Subscribe examples now use switch expressions to assign subscriptions directly (if using >= Swift 5.9)
  • Showed how to use unsubscribe in the topics example and in the docs example
  • For the examples that are run in CI, exit(1) whenever an error occurs instead of simply printing errors (examples may build and pass despite warnings/errors #109)
  • Runs the cache example in CI instead of just building it
  • iOS sample app uses MOMENTO_API_KEY env var instead of hardcoded string
  • Updated readme template to use v0.4.0
  • Updated links in readmes to point to specifically the api-keys page or cache page as appropriate

@anitarua anitarua marked this pull request as ready for review January 6, 2024 00:51
@anitarua anitarua requested a review from pgautier404 January 6, 2024 00:51
Copy link
Collaborator

@pgautier404 pgautier404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anitarua anitarua merged commit 905f508 into main Jan 8, 2024
3 checks passed
@anitarua anitarua deleted the small-fixes branch January 8, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants