Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add initial cloud linter command to preview #297

Merged
merged 2 commits into from
Mar 25, 2024
Merged

feat: Add initial cloud linter command to preview #297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bafe88
feat: Add initial cloud linter command to preview
nand4011 Mar 20, 2024
408c4ae
Fix linter issues
nand4011 Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions momento-cli-opts/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,19 @@ Either `--valid-for` or `--never-expire` must be specified.
)]
endpoint: Option<String>,
},
#[command(
about = "**PREVIEW** Query your AWS account to find optimizations with Momento",
before_help = "
!! !!
!! Preview feature !!
!! For more information, contact us at support@gomomento.com. !!
!! !!

This command will be used to fetch information about your Elasticache clusters and DynamoDB tables
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for now, will probably be good to get @tvald to weigh in on the wording here

to help find opportunities for optimizations with Momento.
"
)]
CloudLinter {},
}

#[derive(Debug, Parser)]
Expand Down
4 changes: 4 additions & 0 deletions momento/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ use env_logger::Env;
use error::CliError;
use log::{debug, error, LevelFilter};
use momento::{CredentialProviderBuilder, MomentoError};
use momento_cli_opts::PreviewCommand;
use utils::{console::output_info, user::get_creds_and_config};

use crate::utils::console::console_info;
Expand Down Expand Up @@ -262,6 +263,9 @@ async fn run_momento_command(args: momento_cli_opts::Momento) -> Result<(), CliE
)
.await?;
}
PreviewCommand::CloudLinter { .. } => {
console_info!("Unimplemented")
}
},
}
Ok(())
Expand Down
Loading