chore: makefile for building binary and upload to S3 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honeyAcorn
requested review from
tylerburdsall,
mjindalmotiv8 and
virratanasangpunth
| pipeline-build-arm64v8: | ||
| /sbin/bpftool btf dump file /sys/kernel/btf/vmlinux format c > src/common/bpf/vmlinux.h \ | ||
| && cargo build --release --features bpf \ | ||
| && ./package.sh arm64v8/rezolus.tar.gz target/release/rezolus \ |
There was a problem hiding this comment.
package.sh appears to be missing contents 😅
There was a problem hiding this comment.
🤦 so embarrassed. Fixed now 4ef393e
tylerburdsall
approved these changes
Jul 28, 2023
virratanasangpunth
approved these changes
Jul 31, 2023
| && ./package.sh amd64/rezolus.tar.gz target/release/rezolus \ | ||
|
|
||
| pipeline-build-arm64v8: | ||
| /sbin/bpftool btf dump file /sys/kernel/btf/vmlinux format c > src/common/bpf/vmlinux.h \ |
There was a problem hiding this comment.
you don't need to do this bpftool thing for amd64?
There was a problem hiding this comment.
According to Brian, he said this is only for apple chip, but if it goes wrong then I will come back and fix it! Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are going to upload the rezolus binary to S3 via pipelines.
This way we can use the rezolus and run it in ms2 or mr2 whenever we need them.
There is another PR in pipeline-of-pipelines that uses the makefile here:
https://github.com/momentohq/pipeline-of-pipelines/pull/642
So this makefile will need to be merged first before that PR can be merged.