fix(Input): add conditional spacing for inputSize

momentum-design · Jun 19, 2019 · 5f9b6e0 · 5f9b6e0
1 parent ac2521b
commit 5f9b6e0
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 11 deletions.
diff --git a/react/src/lib/Input/index.js b/react/src/lib/Input/index.js
@@ -237,7 +237,7 @@ class Input extends React.Component {
       <div
         className={
           `md-input-group` +
-          ` ${inputSize}` +
+          `${inputSize ? ` ${inputSize}` : ''}` +
           `${inputSize ? ' columns' : ''}` +
           `${readOnly ? ' read-only' : ''}` +
           `${disabled ? ' disabled' : ''}` +

diff --git a/react/src/lib/Input/tests/__snapshots__/index.spec.js.snap b/react/src/lib/Input/tests/__snapshots__/index.spec.js.snap
@@ -76,7 +76,7 @@ ShallowWrapper {
         "",
         Array [],
       ],
-      "className": "md-input-group ",
+      "className": "md-input-group",
     },
     "ref": null,
     "rendered": Array [
@@ -85,6 +85,7 @@ ShallowWrapper {
         "key": undefined,
         "nodeType": "function",
         "props": Object {
+          "children": null,
           "className": "md-label",
           "htmlFor": "1",
           "label": "test",
@@ -152,7 +153,7 @@ ShallowWrapper {
           "",
           Array [],
         ],
-        "className": "md-input-group ",
+        "className": "md-input-group",
       },
       "ref": null,
       "rendered": Array [
@@ -161,6 +162,7 @@ ShallowWrapper {
           "key": undefined,
           "nodeType": "function",
           "props": Object {
+            "children": null,
             "className": "md-label",
             "htmlFor": "1",
             "label": "test",
@@ -306,7 +308,7 @@ ShallowWrapper {
         "",
         Array [],
       ],
-      "className": "md-input-group ",
+      "className": "md-input-group",
     },
     "ref": null,
     "rendered": Array [
@@ -315,6 +317,7 @@ ShallowWrapper {
         "key": undefined,
         "nodeType": "function",
         "props": Object {
+          "children": null,
           "className": "md-label",
           "htmlFor": "1",
           "label": "test",
@@ -415,7 +418,7 @@ ShallowWrapper {
           "",
           Array [],
         ],
-        "className": "md-input-group ",
+        "className": "md-input-group",
       },
       "ref": null,
       "rendered": Array [
@@ -424,6 +427,7 @@ ShallowWrapper {
           "key": undefined,
           "nodeType": "function",
           "props": Object {
+            "children": null,
             "className": "md-label",
             "htmlFor": "1",
             "label": "test",
@@ -592,7 +596,7 @@ ShallowWrapper {
         "",
         Array [],
       ],
-      "className": "md-input-group ",
+      "className": "md-input-group",
     },
     "ref": null,
     "rendered": Array [
@@ -601,6 +605,7 @@ ShallowWrapper {
         "key": undefined,
         "nodeType": "function",
         "props": Object {
+          "children": null,
           "className": "md-label",
           "htmlFor": "1",
           "label": "test",
@@ -664,7 +669,7 @@ ShallowWrapper {
           "",
           Array [],
         ],
-        "className": "md-input-group ",
+        "className": "md-input-group",
       },
       "ref": null,
       "rendered": Array [
@@ -673,6 +678,7 @@ ShallowWrapper {
           "key": undefined,
           "nodeType": "function",
           "props": Object {
+            "children": null,
             "className": "md-label",
             "htmlFor": "1",
             "label": "test",
@@ -810,7 +816,7 @@ ShallowWrapper {
         "",
         Array [],
       ],
-      "className": "md-input-group ",
+      "className": "md-input-group",
     },
     "ref": null,
     "rendered": Array [
@@ -819,6 +825,7 @@ ShallowWrapper {
         "key": undefined,
         "nodeType": "function",
         "props": Object {
+          "children": null,
           "className": "md-label",
           "htmlFor": "1",
           "label": "test",
@@ -882,7 +889,7 @@ ShallowWrapper {
           "",
           Array [],
         ],
-        "className": "md-input-group ",
+        "className": "md-input-group",
       },
       "ref": null,
       "rendered": Array [
@@ -891,6 +898,7 @@ ShallowWrapper {
           "key": undefined,
           "nodeType": "function",
           "props": Object {
+            "children": null,
             "className": "md-label",
             "htmlFor": "1",
             "label": "test",
@@ -1028,7 +1036,7 @@ ShallowWrapper {
         "",
         Array [],
       ],
-      "className": "md-input-group ",
+      "className": "md-input-group",
     },
     "ref": null,
     "rendered": Array [
@@ -1037,6 +1045,7 @@ ShallowWrapper {
         "key": undefined,
         "nodeType": "function",
         "props": Object {
+          "children": null,
           "className": "md-label",
           "htmlFor": "1",
           "label": "test",
@@ -1100,7 +1109,7 @@ ShallowWrapper {
           "",
           Array [],
         ],
-        "className": "md-input-group ",
+        "className": "md-input-group",
       },
       "ref": null,
       "rendered": Array [
@@ -1109,6 +1118,7 @@ ShallowWrapper {
           "key": undefined,
           "nodeType": "function",
           "props": Object {
+            "children": null,
             "className": "md-label",
             "htmlFor": "1",
             "label": "test",