Skip to content

Commit

Permalink
chore: mdv2 table color tokens (#1854)
Browse files Browse the repository at this point in the history
  • Loading branch information
NotNestor authored Dec 20, 2024
1 parent b58428e commit 9d1afd9
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 8 deletions.
1 change: 1 addition & 0 deletions web-components/src/wc_scss/themes/global--dark.scss
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@

--md-table-primary-bg-color: #{$md-gray-80};
--md-table-header-bg-color: #{$md-gray-95};
--md-table-header-text-color: var(--md-secondary-text-color);
--md-table-header-border-bottom: none;
--md-table-cell-border-bottom: 1px solid #{$mds-color-theme-outline-secondary-normal};
--md-table-border-style: solid;
Expand Down
1 change: 1 addition & 0 deletions web-components/src/wc_scss/themes/global--light.scss
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@

--md-table-primary-bg-color: #{$md-gray-20};
--md-table-header-bg-color: #{$md-gray-05};
--md-table-header-text-color: var(--md-secondary-text-color);
--md-table-header-border-bottom: none;
--md-table-cell-border-bottom: 1px solid #{$mds-color-theme-outline-secondary-normal};
--md-table-border-style: solid;
Expand Down
18 changes: 10 additions & 8 deletions web-components/src/wc_scss/themes/global--mdv2.scss
Original file line number Diff line number Diff line change
Expand Up @@ -143,14 +143,16 @@ $inter-medium-font: "Inter Medium", $font-family-sans-serif;
* Temporarily disable overriding table background colours for mdv2
*
**/
// --md-table-primary-bg-color: #{$mds-color-theme-background-primary-ghost};
// --md-table-header-bg-color: #{$mds-color-theme-background-primary-ghost};
// --md-table-header-border-bottom: 0 -1px 0 0 #{$mds-color-theme-outline-primary-normal} inset;
// --md-table-cell-border-bottom: 1px solid #{$mds-color-theme-outline-secondary-normal};
// --md-table-border-style: none;
// --md-table-sub-nav-bg-color: #{$mds-color-theme-background-primary-hover};
// --md-table-vertical-divider-color: #{$mds-color-theme-outline-secondary-normal};
// --md-table-pinned-border-color: #{$mds-color-theme-outline-share-inactive};
--md-table-primary-bg-color: #{$mds-color-theme-background-primary-ghost};
--md-table-header-bg-color: #{$mds-color-theme-background-primary-ghost};
--md-table-header-text-color: #{$mds-color-theme-text-primary-normal};
--md-table-header-border-bottom: 0 -1px 0 0 #{$mds-color-theme-outline-primary-normal} inset;
--md-table-cell-border-bottom: 1px solid #{$mds-color-theme-outline-secondary-normal};
--md-table-border-style: none;
--md-table-sub-nav-bg-color: #{$mds-color-theme-background-primary-hover};
--md-table-vertical-divider-color: #{$mds-color-theme-outline-secondary-normal};
--md-table-pinned-border-color: #{$mds-color-theme-outline-share-inactive};


// Background colors can not be overwritten because they are being used by consumers in unexpected ways
// New background colors should be introduced and these phased out
Expand Down

0 comments on commit 9d1afd9

Please sign in to comment.