Bundle size (#1844)

* chore: reduce dropdown list item text size * chore: reduce icon mapping json size * chore: update tab style and dropdown font size * chore: increment package version --------- Co-authored-by: James Nestor <jnestor@cisco.com>
momentum-design · Dec 3, 2024 · a087446 · a087446
1 parent db91488
commit a087446
Show file tree

Hide file tree

Showing 17 changed files with 981 additions and 3,182 deletions.
diff --git a/web-components/package.json b/web-components/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@momentum-ui/web-components",
-  "version": "2.16.3",
+  "version": "2.16.4",
   "author": "Yana Harris",
   "license": "MIT",
   "repository": "https://github.com/momentum-design/momentum-ui.git",

diff --git a/web-components/src/[sandbox]/examples/icon.ts b/web-components/src/[sandbox]/examples/icon.ts
@@ -39,6 +39,7 @@ export const iconTemplate = html`
     size="50"
     color="var(--avatar-presence-active)"
   ></md-icon>
+  <md-icon name="queue-contact-bold" iconSet="momentumDesign" title="queue-contact-bold" size="32"></md-icon>
 
   <h3>Logos (svg) from Brand Visuals Library</h3>
   <md-icon

diff --git a/web-components/src/components/dropdown/scss/dropdown.scss b/web-components/src/components/dropdown/scss/dropdown.scss
@@ -83,8 +83,7 @@
       top: calc(100% + #{$dropdown-main-indent});
       width: 100%;
       z-index: 99;
-      padding: calc((var(--dropdown-list-padding) / 16) * 1rem);
-      font-size: var(--body-primary-font-size, inherit);
+      padding: calc((var(--dropdown-list-padding) / 16) * 1rem);      
     }
 
     &-option {

diff --git a/web-components/src/components/icon/Icon.ts b/web-components/src/components/icon/Icon.ts
@@ -274,7 +274,7 @@ export namespace Icon {
       if (this.iconSet === "momentumDesign" || this.iconSet === "momentumBrandVisuals") {
         return this.name;
       }
-      const lookupName = this.getIconName();
+      const lookupName = this.momentumUIIconLookupName;
       const mappedName = ELEMENT.designLookup.get(lookupName);
 
       return mappedName ?? lookupName;
@@ -368,6 +368,14 @@ export namespace Icon {
       };
     }
 
+    get momentumUIIconLookupName() {
+      //The lookup map has the icon name without the size
+      let iconName = this.name;
+      iconName = iconName.startsWith("icon-") ? iconName.substring(5) : iconName;
+      iconName = iconName.split("_")[0];
+      return iconName;
+    }
+
     getIconName() {
       let iconName = this.name;
       iconName = iconName.startsWith("icon-") ? iconName.substring(5) : iconName;