Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): tooltip type warning due to incorrect use of oneOf #789

Merged
merged 2 commits into from
Feb 25, 2021

Conversation

Coread
Copy link
Collaborator

@Coread Coread commented Feb 24, 2021

Description

Small fix to correct the expected type for the react tooltip component tooltip prop

Related Issue

#788

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@robstax robstax mentioned this pull request Feb 24, 2021
15 tasks
robstax
robstax previously approved these changes Feb 24, 2021
@yjlo yjlo self-requested a review February 24, 2021 18:52
yjlo
yjlo previously approved these changes Feb 24, 2021
@robstax
Copy link
Collaborator

robstax commented Feb 24, 2021

not sure why this PR won't run any checks... i'd like to get this in, the warning logs are quite annoying

@Coread Coread dismissed stale reviews from yjlo and robstax via 47ebc50 February 25, 2021 09:29
@Coread Coread changed the title fix: tooltip type warning due to incorrect use of oneOf fix(tooltip): tooltip type warning due to incorrect use of oneOf Feb 25, 2021
@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #789 (856f79b) into master (c88cf09) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #789      +/-   ##
==========================================
- Coverage   94.14%   94.13%   -0.02%     
==========================================
  Files         125      125              
  Lines       14657    14657              
  Branches     2155     2157       +2     
==========================================
- Hits        13799    13797       -2     
- Misses        858      860       +2     
Impacted Files Coverage Δ
web-components/src/components/icon/Icon.ts 78.57% <0.00%> (-4.17%) ⬇️
web-components/src/components/button/Button.ts 79.22% <0.00%> (+0.27%) ⬆️
web-components/src/components/menu/MenuItem.ts 98.75% <0.00%> (+1.25%) ⬆️
web-components/src/components/label/Label.ts 100.00% <0.00%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c88cf09...856f79b. Read the comment docs.

@robstax robstax merged commit 12ad408 into momentum-design:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants