Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): fix tooltip proptype #790

Closed
wants to merge 4 commits into from
Closed

Conversation

robstax
Copy link
Collaborator

@robstax robstax commented Feb 24, 2021

Tooltip PropTypes were wrong and spewing a lot of PropType error messages.

Description

oneOf should be oneOfType

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@robstax
Copy link
Collaborator Author

robstax commented Feb 24, 2021

closing because #789 beat me to the punch! hahaha...

@robstax robstax closed this Feb 24, 2021
@robstax robstax reopened this Feb 24, 2021
@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #790 (e5c2270) into master (32088ee) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #790      +/-   ##
==========================================
+ Coverage   94.08%   94.12%   +0.04%     
==========================================
  Files         125      125              
  Lines       14657    14657              
  Branches     2157     2161       +4     
==========================================
+ Hits        13790    13796       +6     
+ Misses        867      861       -6     
Impacted Files Coverage Δ
web-components/src/mixins/RovingTabIndexMixin.ts 93.63% <0.00%> (-3.64%) ⬇️
...components/src/components/datepicker/DatePicker.ts 88.53% <0.00%> (-1.19%) ⬇️
web-components/src/mixins/SlottedMixin.ts 100.00% <0.00%> (+1.80%) ⬆️
web-components/src/components/list/ListItem.ts 100.00% <0.00%> (+2.94%) ⬆️
web-components/src/components/icon/Icon.ts 81.54% <0.00%> (+2.97%) ⬆️
...mponents/src/components/draggable/DraggableItem.ts 100.00% <0.00%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32088ee...e5c2270. Read the comment docs.

@robstax robstax closed this Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant