Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): fix the yarn.lock file #1364

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Coread
Copy link
Collaborator

@Coread Coread commented Oct 10, 2022

Description

Attempt at fixing the lock file issues brought in by #1350

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Base: 94.02% // Head: 93.98% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (a11b515) compared to base (b73c360).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1364      +/-   ##
==========================================
- Coverage   94.02%   93.98%   -0.04%     
==========================================
  Files         132      132              
  Lines       18176    18176              
  Branches     2769     2767       -2     
==========================================
- Hits        17090    17083       -7     
- Misses       1086     1093       +7     
Impacted Files Coverage Δ
web-components/src/mixins/RovingTabIndexMixin.ts 93.63% <0.00%> (-3.64%) ⬇️
web-components/src/components/list/ListItem.ts 97.05% <0.00%> (-2.95%) ⬇️
...eb-components/src/components/help-text/HelpText.ts 98.33% <0.00%> (-1.67%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants