Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 'live' icon svg #1435

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

BartSu
Copy link

@BartSu BartSu commented Mar 17, 2023

Description

update live icon svg

Related Issue

fix live icon svg, getting rid of 'filled-rule' attribute

Motivation and Context

script may cannot handle filled-rule

How Has This Been Tested?

local test

Screenshots:

Before (If applicable):

After:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.50 🎉

Comparison is base (7516dfd) 93.83% compared to head (8376bc6) 94.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1435      +/-   ##
==========================================
+ Coverage   93.83%   94.34%   +0.50%     
==========================================
  Files         132      132              
  Lines       18279    18279              
  Branches     2780     2806      +26     
==========================================
+ Hits        17152    17245      +93     
+ Misses       1127     1034      -93     

see 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant