Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(listitem): allows optional change of role #723

Merged
merged 3 commits into from
Dec 8, 2020

Conversation

yjlo
Copy link
Collaborator

@yjlo yjlo commented Dec 8, 2020

Description

Added optional prop specifyRoleWithoutList to allow ListItem roles to be determined by the component itself and not just by List

Related Issue

Motivation and Context

https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-168346
Needed for this JIRA for the space list filter menu

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@holsted holsted merged commit 7ce1dc9 into momentum-design:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants