Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): bumped node version to 14.15.1 #746

Merged
merged 2 commits into from
Jan 14, 2021

Conversation

peter7cole
Copy link
Contributor

@peter7cole peter7cole commented Jan 8, 2021

Description

Hailing from Cisco Online Account Management Portal, we are trying to update our project to the most recent stable Node release, and found we needed to update MomentumUI as well to accomplish that. The change to the react library passed build and tests locally.

Related Issue

Issue #745

Motivation and Context

This will keep more Cisco projects up to date.

How Has This Been Tested?

Ran yarn build & yarn test locally.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Collaborator

@chrisadubois chrisadubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes. Ben or Yan Jen or Rob?

@chrisadubois
Copy link
Collaborator

This might impact the web client and a few other repos FYI. So we need to check in with them. Some of the ecomm experiences use this too.

@peter7cole
Copy link
Contributor Author

@bfbiggs, are you able to review this?

@elenagiere elenagiere merged commit 9393d47 into momentum-design:master Jan 14, 2021
@peter7cole peter7cole deleted the node-bump-14 branch March 5, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants