Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 7.2系へアップデート #819

Merged
merged 8 commits into from
Dec 30, 2024

Conversation

yonta
Copy link
Collaborator

@yonta yonta commented Dec 30, 2024

featureブランチへのマージ!

Rails 7.2!

やったこと

  • Rails 7.2.2.1へアップデート
    • rails app:update に従い7.2系の設定にアップデート
      • Rails設定のdiffを確認し、自分たちで設定した項目以外はデフォルトに追従した
      • rails generate コマンド実行後にRubocopフォーマットをかけるようにした
    • Railsのデフォルト動作をv7.2にした
  • 警告「Rails 8.0で削除予定のenumの定義」を修正した

@yonta yonta changed the base branch from main to feature/rails7.2/base December 30, 2024 08:13
Copy link

github-actions bot commented Dec 30, 2024

📦 esbuild Bundle Analysis for sakazuki

This analysis was generated by esbuild-bundle-analyzer. 🤖
This PR introduced no changes to the esbuild bundle! 🙌

@yonta yonta marked this pull request as ready for review December 30, 2024 08:17
@yonta yonta self-assigned this Dec 30, 2024
@github-actions github-actions bot requested a review from momocus December 30, 2024 08:17
@yonta yonta force-pushed the feature/rails7.2/base branch from 3c25fb7 to 7080a83 Compare December 30, 2024 08:20
警告内容は以下のようなもの。

DEPRECATION WARNING: Defining enums with keyword arguments is deprecated and will be removed
in Rails 8.0. Positional arguments should be used instead
- rails app:update を実行
  - Rails設定のdiffを確認し、自分たちで設定した項目以外はデフォルトに追従した
  - rails generate コマンド実行後にRubocopフォーマットをかけるようにした
- rails app:updateを実行
  - Rails設定のdiffに従い、絵文字設定のコメントアウト文を追加した
@yonta yonta force-pushed the feature/rails7.2/rails7.2 branch from d489343 to 0e67b04 Compare December 30, 2024 08:21
@momocus momocus merged commit 054341b into feature/rails7.2/base Dec 30, 2024
3 checks passed
@momocus momocus deleted the feature/rails7.2/rails7.2 branch December 30, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants