Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update query packs to not use deprecated fields #163

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Update query packs to not use deprecated fields #163

merged 4 commits into from
Sep 18, 2024

Conversation

tas50
Copy link
Member

@tas50 tas50 commented Sep 10, 2024

  • RDS clusters and instances were renamed
  • Remove a duplicate ElastiCache query that used the old field

@tas50
Update query packs to not use deprecated fields
0619990 
- RDS clusters and instances were renamed
- Remove a duplicate ElastiCache query that used the old field

Signed-off-by: Tim Smith <tsmith84@gmail.com>
@tas50
Update from query to mql
7600fdc 
Signed-off-by: Tim Smith <tsmith84@gmail.com>
@HRouhani
Copy link
Contributor

@tas50
any reason you removed:

  - uid: mondoo-asset-count-aws-elasticache-clusters
    title: AWS ElastiCache Clusters
    mql: aws.elasticache.clusters.length

This is the reason the pipeline failed!

@tas50
Remove the reference to the removed check
47f6404 
Signed-off-by: Tim Smith <tsmith84@gmail.com>
@tas50
Copy link
Member Author

tas50 commented Sep 17, 2024

@HRouhani I updated the policy to remove that reference. We had 2 queries that were actually the same query. One used the original resource name and one used the new name. I removed the deprecated one.

@tas50
Update spellcheck config
ee9af28 
Slip this in while I'm updating this repo

Signed-off-by: Tim Smith <tsmith84@gmail.com>
HRouhani
HRouhani approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@HRouhani HRouhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tim

@HRouhani HRouhani merged commit 42cebde into main Sep 18, 2024
6 checks passed
@HRouhani HRouhani deleted the tas50/handle_deprecations branch September 18, 2024 08:24
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HRouhani HRouhani HRouhani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tas50 @HRouhani