🐛 Properly target the region filter.

providers/aws/config/config.go

@@ -97,7 +97,7 @@ var Config = plugin.Provider{
 					Long:    "filters",
 					Type:    plugin.FlagType_KeyValue,
 					Default: "",
-					Desc:    "Filter options",
+					Desc:    "Filter options e.g cnquery shell aws --filters region=us-east-2",
 				},
 			},
 		},

providers/aws/connection/connection.go

@@ -110,7 +110,7 @@ func NewAwsConnection(id uint32, asset *inventory.Asset, conf *inventory.Config)
 	c.connectionOptions = asset.Options
 	if conf.Discover != nil {
 		c.Filters = parseOptsToFilters(conf.Discover.Filter)
-		c.RegionLimits = c.Filters.GeneralDiscoveryFilters.Regions
+		c.RegionLimits = firstNonEmptyRegion(c.Filters.GeneralDiscoveryFilters.Regions, c.Filters.Ec2DiscoveryFilters.Regions)
 	}
 	return c, nil
 }
@@ -288,6 +288,14 @@ func CheckRegion(cfg aws.Config) error {
 	return nil
 }
 
+// firstNonEmptyRegion determines and return the first non-empty region.
+func firstNonEmptyRegion(generalRegion, ec2Region []string) []string {
+	if len(ec2Region) > 0 {
+		return ec2Region
+	}
+	return generalRegion
+}
+
 func CheckIam(cfg aws.Config) (*sts.GetCallerIdentityOutput, error) {
 	ctx := context.Background()
 	svc := sts.NewFromConfig(cfg)

providers/aws/connection/connection_test.go

@@ -0,0 +1,42 @@
+package connection
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/require"
+)
+
+func TestFirstNonEmptyRegion(t *testing.T) {
+	tests := []struct {
+		name          string
+		generalRegion []string
+		ec2Region     []string
+		expected      []string
+	}{
+		{
+			name:          "EC2Region Non-Empty, GeneralRegion Empty",
+			generalRegion: []string{},
+			ec2Region:     []string{"us-west-2", "us-east-1"},
+			expected:      []string{"us-west-2", "us-east-1"},
+		},
+		{
+			name:          "EC2Region Empty, GeneralRegion Non-Empty",
+			generalRegion: []string{"eu-central-1", "eu-west-3"},
+			ec2Region:     []string{},
+			expected:      []string{"eu-central-1", "eu-west-3"},
+		},
+		{
+			name:          "Both Empty",
+			generalRegion: []string{},
+			ec2Region:     []string{},
+			expected:      []string{},
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			result := firstNonEmptyRegion(tt.generalRegion, tt.ec2Region)
+			require.Equal(t, tt.expected, result, "firstNonEmptyRegion did not return the expected result")
+		})
+	}
+}

providers/aws/provider/provider.go

@@ -93,7 +93,7 @@ func parseFlagsToFiltersOpts(m map[string]*llx.Primitive) map[string]string {
 			if k == "instance-id" {
 				o[k] = string(v.Value)
 			}
-			if strings.Contains(k, ":region") {
+			if strings.Contains(k, "region") {
 				o[k] = string(v.Value)
 			}
 		}