Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Guzzle #138

Closed
wants to merge 4 commits into from
Closed

use Guzzle #138

wants to merge 4 commits into from

Conversation

recanman
Copy link
Contributor

@recanman recanman commented Aug 11, 2023

This does break compatibility with other daemon RPC methods, so I am leaving it as a draft for now. It is very simple to fix and make it compatible with the other methods, but I will not, as I am waiting to port the classes to PHP 8.

This also adds composer.lock, which for some reason, is not included.

Closes #81, #92

@recanman recanman mentioned this pull request Aug 19, 2023
10 tasks
@@ -9,172 +9,78 @@
* http://implix.com
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to adapt the header pre-comment. Feel free to add "Monero Integrations Contributors"

@BrianHenryIE
Copy link
Contributor

Ideally, Guzzle should not be in require. Instead, the PSR interfaces should be required:

    "psr/http-client-implementation": "*",
    "psr/http-factory-implementation": "*"

And Guzzle passed in in the constructor

/**
 * Constructor
 *
 * @param RequestFactoryInterface $requestFactory
 * @param ClientInterface $client A PSR HTTP client.
 */
public function __construct(RequestFactoryInterface $requestFactory, ClientInterface $client, ...

E.g. for WordPress plugins, I don't use Guzzle, I use a PSR library that builds on WordPress's Requests library.

This also allows for easier testing.

@recanman recanman mentioned this pull request Aug 30, 2023
@recanman
Copy link
Contributor Author

recanman commented Jan 9, 2024

Closing in favor of merging refring's repository, which has a new structure.

@recanman recanman closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use guzzle instead of jsonRPCClient
3 participants