Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing both total balance and unlocked balance is horrible for new users #2293

Closed
ghost opened this issue Jul 18, 2019 · 15 comments
Closed

Comments

@ghost
Copy link

ghost commented Jul 18, 2019

Proposal (updated! thx for all input! design also includes #2298, #2304):
image
Clicking on (Why?) shows:

"For safety reasons, mainly to prevent double-spending, in Monero there's a waiting time of 10 blocks (~20 minutes) until newly received funds can be spent. In case you have to wait although you haven't received any funds within the last 10 blocks, then you certainly have sent some funds within the last 10 blocks - which also can cause a waiting time. The reason for this is that when you send for example 1 XMR, technically 5 XMR may be send but you get 4 XMR back as change - a process you may not notice at all, but technically the 4 XMR count as newly received funds and cause the same waiting time as regularly received funds."

Reasons:

  • This solution doesn't make Monero look complicated
  • The user only is bothered with locked funds in case it is actually relevant (when he's on the Send page and funds are locked)
  • It is consistent to most other crypto wallets: They won't show you 2 different balances only because some funds might not have enough confirmations yet.
@rating89us
Copy link
Contributor

I agree 100%. Displaying a single balance is much better.

@sanderfoobar
Copy link
Contributor

WHAT THE COMMUNITY THINKS IN GENERAL ABOUT MY RECOMMENDATIONS FOCUSED ON MAKING MONERO EASY FOR NEW USERS. Because I suspect veterans here don't like it too much

Could you expand on that? As active contributor I feel responsible for making sure people feel welcome whilst submitting issues - if you think this is not the case please specifically outline why so we can improve our process.

As for the proposal itself, first impression is that I like the idea.

@ghost
Copy link
Author

ghost commented Jul 18, 2019

@xmrdsc My proposals just didn't get adopted (yet). Probably it was wrong from me to expect that to happen quickly. And I wonder if "appeal to new users" is considered important here or not so much. I would understand the latter, given that developer resources are limited!

Thanks for liking the proposal!

@dEBRUYNE-1
Copy link
Contributor

@Realchacal - fwiw, selsta is working on your suggestion in #2211.

@dEBRUYNE-1
Copy link
Contributor

It is consistent to every other (Bitcoin) wallet: They never show you 2 different balances only because some funds might not have enough confirmations yet.

New outputs in Bitcoin aren't actually locked, i.e., you can spend them immediately. By contrast, in Monero they are actually locked for ten blocks. The ten blocks lock time is a security measure.

You have NO clue what's going on. It is NOT self explaining

I think you are being a bit dramatic here. If there is discrepancy between total balance and unlocked balance, it is kind of obvious that part of the balance is not spendable yet. Additionally, the GUI shows that it will take x minutes for this part of the balance to become spendable again.

how long

The GUI shows how long it takes for them to unlock.

That being said, I like your suggestion of showing a single balance with an appropriate warning message on the Send page in case of part of the balance still being locked.

@erciccione
Copy link
Collaborator

That being said, I like your suggestion of showing a single balance with an appropriate warning message on the Send page in case of part of the balance still being locked.

+1. With the only difference that i would add a link to the guide or to somwhere else where it's explained why there is a locked balance. Just to not leave the user confused on why they cannot use all the balance.

@ghost
Copy link
Author

ghost commented Jul 18, 2019

@dEBRUYNE-1

The GUI shows how long it takes for them to unlock.

Sorry, I didn't know! Thanks.

@ghost
Copy link
Author

ghost commented Jul 18, 2019

+1. With the only difference that i would add a link to the guide or to somewhere else where it's explained

Ok! I made an explanation that could be used as a popup or tooltip:

For safety reasons, mainly to prevent double-spending, you have to wait 10 blocks (~20 minutes) until newly received funds can be spent. Please note that sending funds also may lead to such a waiting time. The reason for this is that sending funds usually involves getting back some change, which is handled in the background without you noticing it, but technically counts as newly received funds.

@GBKS
Copy link
Contributor

GBKS commented Jul 19, 2019

Here's an exploration around simplifying the balance display and keeping the information about locked amounts inside the balance card. The big message with the warning sign in the send screen just seems a bit overkill. Big alert messages should be things that are super important for users to see and act on. I'd find a subtler treatment more appropriate.

monero-balance-cards-gbks-190718

And yes, it has also bugged me to see two balances with the same visual weight. Always takes me a second to figure out what's what.

@ghost
Copy link
Author

ghost commented Jul 19, 2019

@GBKS What you've done looks REALLY, REALLY great! But:

  • The big warning sign is NOT overkill, because it's only shown in the Send page and only if funds are actually locked. But I'd totally agree to make the sign smaller or change the message! If you've got any proposals for that, you seem to be very talented to see what looks good!
  • Showing how much is locked is not of primary interest. What's AVAILABLE is more of interest!
  • The main idea was not to bother the (new) user with something strange ("locked funds") that he is not familiar with.
  • In Improve balance readability / balance card overhaul #2298 we (you and me^^) are currently discussing to overhaul the balance window anyway. That would make your proposal here obsolete.

Conclusion: I'm against your proposal (Sorry! I'm not saying it's bad, it's an excellent proposal! But I'm still against it for the given reasons.)

Thank you for pointing out that seeing 2 balances always needs a second look, even for veterans!

@rating89us
Copy link
Contributor

Balance card should display total balance only.
Send page should display available balance.

@ghost
Copy link
Author

ghost commented Aug 12, 2019

@selsta do I close this, too, and integrate it in #2298?

@selsta
Copy link
Collaborator

selsta commented Aug 13, 2019

@Realchacal yes I’d add it to #2298.

@ghost
Copy link
Author

ghost commented Aug 13, 2019

Closed and integrated in #2298.

@ghost ghost closed this as completed Aug 13, 2019
@dentuwu
Copy link

dentuwu commented Jun 22, 2023

you very rich

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants