Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wallet name to title bar #2325

Closed
ghost opened this issue Jul 27, 2019 · 13 comments · Fixed by #2376
Closed

Add wallet name to title bar #2325

ghost opened this issue Jul 27, 2019 · 13 comments · Fixed by #2376

Comments

@ghost
Copy link

ghost commented Jul 27, 2019

[Updated! Thx @GBKS]
image
(Ignore changes from #2298, #2339, #2304.)

This is financial safety-critical because it's super easy to confuse wallets when the name is not shown prominently.

Alternative:
image

@rating89us
Copy link
Contributor

Where would you get the wallet's title from? From the .keys file?

@ghost
Copy link
Author

ghost commented Jul 28, 2019

Sure!

@rating89us
Copy link
Contributor

rating89us commented Jul 28, 2019

That's a good idea. Window title should be "Mywallet.keys - Monero GUI"
Logo should be removed from title.

@ghost
Copy link
Author

ghost commented Jul 28, 2019

  • Agreed on putting the wallet name in front and dropping the logo.
  • Not so sure about adding .keys. A normal user probably isn't aware at all that his wallet file actually is a .keys file. Even when opening a wallet the wallet names are presented without .keys.

@rating89us
Copy link
Contributor

rating89us commented Jul 28, 2019

Maybe we should start educating our users that a Monero wallet is nothing more than a .keys file.

What about displaying .keys extension when in Advanced wallet, and don't displaying it in simple mode?

@ghost
Copy link
Author

ghost commented Jul 28, 2019

Maybe we should start educating our users that a Monero wallet is nothing more than a .keys file.

I think we can be happy enough if all users understand the basic safety concept of mnemonic seeds. We want to board millions of normal people in the future! :)

What about displaying .keys extension when in Advanced wallet, and don't displaying it in simple mode?

Advanced users rather wouldn't need it.

@GBKS
Copy link
Contributor

GBKS commented Jul 30, 2019

How about removing "Monero" from the title bar altogether and just show the wallet name? It's not shown anyways if you disable custom decorations. The logo is still shown in the balance card on the left.

@ghost
Copy link
Author

ghost commented Jul 30, 2019

@GBKS That would be awesome!!!

@dginovker
Copy link

@GBKS I'd rather see both variations before deciding on that. To avoid clutter on small resolution monitors, I could see it working well for taskbars, but on the actual GUI bar it offers aesthetics

@ghost ghost changed the title Improve title bar Add wallet name to title bar Sep 3, 2019
@ghost
Copy link
Author

ghost commented Sep 4, 2019

I'd rather see both variations before deciding on that.

Proposal updated now showing @GBKS's variant. By far the best. (For older variants see "edited".)

@selsta
Copy link
Collaborator

selsta commented Sep 4, 2019

See #2376.

menubar

Also ping @dEBRUYNE-1, what do you think of not having the Monero logo in the titlebar?

@ghost
Copy link
Author

ghost commented Sep 5, 2019

Very nice but font size should be much smaller (like the title before).

The logo adds visual complexity. In case you want the logo for clarity, this would be more helpful and simpler visually:

image
(2 blanks before and after the dash.)

@selsta
Copy link
Collaborator

selsta commented Sep 5, 2019

I reduced the font size from 24 to 20.

This was referenced Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants