Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accounts as tabs #2367

Open
ghost opened this issue Sep 1, 2019 · 9 comments
Open

Accounts as tabs #2367

ghost opened this issue Sep 1, 2019 · 9 comments

Comments

@ghost
Copy link

ghost commented Sep 1, 2019

image

image

Alternative (more intuitive since the Accounts page itself isn't shown as tab):
image

@kayront
Copy link

kayront commented Sep 1, 2019

I really like this.

Monero is nearly uniquely positioned to offer the accounts functionality because of on-chain privacy being on by default. I've made use of the accounts feature in the cli for a long time, and wouldn't have it otherwise: it's personal finance 101 to keep stuff separate.

I really like the work you guys have been doing, the wallet looks better and better. I'm very appreciative of the fact that we have people like you working on the project.

@realindiahotel
Copy link

Sexy

@potatoisfood
Copy link

potatoisfood commented Sep 1, 2019

Some GUI updates

1 Lets get rid of the left hand side menu’s sub-buttons.
Send button has one sub-button. Address Book.
Receive button has one sub-button. Merchant.
Advanced button has four sub-buttons. Mining, Prove/check, Shared RingDB and Sign/verify.

Settings button has no sub-buttons in the menu. Instead the buttons are at the top edge of the Settings page. Lets do it this way with Send and Advanced buttons. So sub-buttons to the top edge of each page. And they should be exactly like buttons on Settings page. Horizontally at the top edge of the page.

Receive buttons Merchant sub-button has so different functionality than rest of the wallet, that it could look very different than the other buttons and could be located somewhere bottom edge of the Receive page.

2 We could combine the Advanced and the Settings buttons in to one button. That could be called just Settings button. At the top edge of the settings page there would be located horizontally Wallet, Interface, Node, Log, Info, Mining, Prove/check, Shared RingDB and Sign/verify buttons. They could be in one or two rows depending how much there is space. And they really should look like they look now at the Settings page, and be horizontally, because the look so good.

3 The Setting button's written word Settings could be replaced by a cogwheel symbol. Once there is, for a written word, a widely know symbol, it should be used. And remember, less text, more intuitive. The cogwheel symbol could be located at the bottom left corner of the wallet.

It would be great to show for a friend or for a noob GUI wallet and say, hey this all you need to know to use wallet, Account, Send and Receive.

@ghost
Copy link
Author

ghost commented Sep 2, 2019

@potatoisfood: Sorry but your comment is mostly off-topic for this issue.

@1blockologist
Copy link

1blockologist commented Sep 4, 2019

I would prefer the GUI allows for multiple wallets to be opened instead of simply elevating multiple subaddresses.

The tabs should be for different wallets being scanned.

This would allow for more consistent real world accounting purposes, while continuing to promote single use addresses.

"trading" and "retirement" as only a single distinct subaddress instead of a separate wallet is promoting address re-use which is not a privacy feature.

@selsta
Copy link
Collaborator

selsta commented Sep 4, 2019

trading" and "retirement" as only a single distinct subaddress instead of a separate wallet is promoting address re-use which is not a privacy feature.

Accounts can create as many subaddresses as they want. They promote address re-use the same way as a different wallet file would.

I would prefer the GUI allows for multiple wallets to be opened instead of simply elevating multiple subaddresses.

The GUI isn’t built to support multiple wallets so this would require large architectural changes.

The tabs should be for different wallets being scanned.

This performs way worse than accounts.

This would allow for more consistent real world accounting purposes, while continuing to promote single use addresses.

Can you explain why “more consistent real world accounting purposes”? Having to save multiple seeds is a worse UX than having multiple accounts in a single seed.

@1blockologist
Copy link

1blockologist commented Sep 4, 2019

@Realchacal

The tabs represent different accounts, not different subaddresses!

your mockup shows them as one in the same? the 'retirement' tab and the 'trading tab' are also address and subaddress 1 and 2 respectively.

perhaps I am missing something. in your list of accounts, the column says "first address" of each account. does that mean that there is a tree of subaddresses that the current GUI does not show?

@ghost
Copy link
Author

ghost commented Sep 5, 2019

@1blockologist On the Accounts page the current GUI shows only the first subaddress of each account. But every account has many more subaddresses, which you find on the Receive page of each account. This basic concept isn't changed with this proposal.

But I see the problem. Showing addresses on the Accounts page can cause misconceptions like:

  • "Ah, in Monero an account is an address!"
  • "Ah, every account has exactly one address!"
  • "Ah, every account has one account number!"

To fight such misconceptions, I just updated the captions:
image

@1blockologist
Copy link

1blockologist commented Sep 5, 2019

@Realchacal ah I just looked! Thanks for helping me understand that, very amazing!

I don't think this concept is adequately conveyed by either of the GUIs, or the team and this affects the UX critiques and possibilities

I'll mull it over

@ghost ghost mentioned this issue Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants