add account support #1905
Merged
add account support #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selsta
force-pushed
the
account-wip
branch
3 times, most recently
from
15913c1 to
d26bb0f
Compare
|
Update:
|
selsta
force-pushed
the
account-wip
branch
3 times, most recently
from
25c4371 to
2b9eee7
Compare
|
Ready for testing/reviews now :) |
selsta
force-pushed
the
account-wip
branch
2 times, most recently
from
eb4d4bc to
594dbe2
Compare
mmbyday
suggested changes
Jan 22, 2019
Co-authored-by: kenshi84 <kenshi84@protonmail.ch>
mmbyday
approved these changes
Jan 23, 2019
|
Very cool PR. One question, does the history page still work or did this PR break it? It doesn't list transactions. Perhaps local problem here. |
|
Every account has its own history. Also there’s currently a bug in master that the history page doesn’t load sometimes but that’s not related to this PR. Selecting the current date fixes it. |
sanderfoobar
approved these changes
Jan 24, 2019
luigi1111
added a commit
that referenced
this pull request
Feb 1, 2019
bd809ab add account support (selsta)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated and rebased version of #793
Known bugs:
I’d appreciate feedback!