Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SettingsNode: redesign stop/keep local node running #2898

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SettingsNode: redesign stop/keep local node running #2898

wants to merge 1 commit into from

Conversation

rating89us
Copy link
Contributor

@rating89us rating89us commented May 11, 2020 •
edited
Loading

Changes:

pages/settings/SettingsNode.qml:

  • Added dropdown to default action "When closing GUI wallet or connecting to a remote node" with options 1) Stop local node 2) Keep local node running (recommended) 3) Always ask whether the node should be stopped

main.qml:

  • The stop/keep local node dialog is not full screen anymore
  • Updated text with better explanation about the importance of keeping local node running
  • removed close (x) button from the dialog

@rating89us rating89us changed the title SettingsNode: dropdown (stop/keep local node when closing GUI) SettingsNode: dropdown (stop/keep local node when closing GUI/starting remote node) May 11, 2020
@rating89us rating89us changed the title SettingsNode: dropdown (stop/keep local node when closing GUI/starting remote node) SettingsNode: redesign stop/keep local node running May 11, 2020
@xiphon
Copy link
Collaborator

xiphon commented May 13, 2020

Please split into separate PRs

@rating89us rating89us force-pushed the patch-23 branch 2 times, most recently from 8cd361f to 5da789c Compare May 15, 2020 10:53
@rating89us rating89us mentioned this pull request Nov 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rating89us @xiphon