DaemonManager: take dataDir into account when sending cmd #4047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selsta
force-pushed
the
send-command-datadir
branch
from
0d12cd9
to
529aed3
Compare
selsta
force-pushed
the
send-command-datadir
branch
from
529aed3
to
80ade41
Compare
|
using this PR - no bitmonero.log file is created in the default dir when stopping/starting/re-opening the gui edit: selsta took the time to explain to me exactly the reason for this problem, and how it is just needs to duplicate behaviour elsewhere. that's the only reason i could have reviewed this after testing |
plowsof
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4046