Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect CMake install paths #4338

Closed
wants to merge 1 commit into from

Conversation

aperechnev
Copy link

@aperechnev aperechnev commented Aug 19, 2024

There is CMakeLists.txt file with an absolute installation path:

install(TARGETS monero-wallet-gui
  DESTINATION bin
)

where bin usually points to /usr/local/bin.

It works well, but if some build system attempts to produce a package, it will fail since a user might not have root privileges. Such build systems usually place artifacts in a dedicated directory, like ~/my-package/usr/local/bin/. As an example, FreeBSD's Makefile and Poudriere always fail during the insufficient access rights. I believe this is not the only case.

So I just changed the installation path to respect CMake prefixes according to CMake documentation:

install(TARGETS monero-wallet-gui
  DESTINATION ${CMAKE_INSTALL_BINDIR}
)

And now the produced executable can be placed to the right directory.

@aperechnev aperechnev marked this pull request as draft August 20, 2024 18:53
@aperechnev aperechnev closed this Sep 1, 2024
@aperechnev aperechnev deleted the cmake-paths branch September 1, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant