Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user guides: uniform structure of verification-allos-advanced.md, verification-windows-beginner.md, view_only.md, andbps_run_node.md #1433

Closed
wants to merge 4 commits into from

Conversation

erciccione
Copy link
Contributor

Part of #1270

@netlify
Copy link

netlify bot commented Jan 23, 2021

Deploy preview for barolo-time-757cf9 ready!

Built with commit 5437853

https://deploy-preview-1433--barolo-time-757cf9.netlify.app

@ghost
Copy link

ghost commented Feb 24, 2021

Should newlines be taken into account when comparing the structure of each file? I see some inconsistencies, but I'm not familiar enough with po4a to know whether they cause issues or not.

@erciccione
Copy link
Contributor Author

From my tests seems that the important is that paragraphs of texts are separated by a newline. Multiple newlines shouldn't effect po4a's parsing.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the following lines (161-163) from _i18n/de/resources/user-guides/verification-windows-beginner.md:

Behalte die Auswahl von `Certify only for myself` bei und klicke auf `Certify`.

![kleo certify for self](png/verify_binary_windows_beginner/verify-win_kleopatra-certify-forself.png)

@erciccione
Copy link
Contributor Author

Multiple newlines shouldn't effect po4a's parsing.

I had some doubts about this so i'm making more tests with different files and looks like the files have to match line by line (so mismatching newlines would be a problem). I'm looking into the best way to push the converted files. Let's put this PR in stand by, because might be superseded by another one.

@erciccione
Copy link
Contributor Author

Closing this. i will include these changes when creating the .po files of the related guides.

@erciccione erciccione closed this Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant