Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: drop support for 32-bit windows target #9470

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tobtoht
Copy link
Contributor

@tobtoht tobtoht commented Sep 4, 2024

Discussion: https://libera.monerologs.net/monero-research-lab/20240904#c422227-c422235
Context: #9436 (review)

The last commercially available x86 processors were released over 18 years ago. Windows 11 requires 64-bit.

Article from Nov 2021:

The first 32-bit Windows version in the charts is Windows 7 with a share of 0.22 percent, followed by its Windows 10 sibling with 0.09 percent.

https://news.softpedia.com/news/new-data-shows-windows-32-bit-is-becoming-a-thing-of-the-past-534336.shtml

Copy link
Contributor

@sneurlax sneurlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes themselves look good to me.

As to the concept, my only opinion is that the first step to opposing it would be to find a 32-bit Windows maintainer. If there aren't devs dedicated to this platform to take up that task, then it should be dropped. Dropping it might bring those devs out of the woodwork later and they can resolve any issues with it then, right?

Copy link
Collaborator

@0xFFFC0000 0xFFFC0000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamamyth
Copy link

iamamyth commented Sep 5, 2024

the first step to opposing it would be to find a 32-bit Windows maintainer

Supporting a platform where both the hardware and software are increasingly unavailable requires not just a maintainer, but others to validate their work. Are there 2-3 people with the requisite configurations willing to put in that effort? How long will CI and build platforms support win32? Until the next hardfork, win32 users can run the existing binaries, so, by the time this decision drops them from the network, the platform would be even more irrelevant.

@One-horse-wagon
Copy link

It is estimated as of 2024, only 4% of windows users use 32 bit systems. They are legacy systems with the total number constantly decreasing. I would think all Monero users anywhere, have access to 64 bit systems, even if they are using a 32 bit system.

@tobtoht tobtoht mentioned this pull request Dec 9, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants