Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: use pkgconfig to find zeromq #9542

Merged
merged 1 commit into from
Dec 23, 2024
Merged

cmake: use pkgconfig to find zeromq #9542

merged 1 commit into from
Dec 23, 2024
+13 −62

Conversation

tobtoht
Copy link
Contributor

@tobtoht tobtoht commented Oct 25, 2024

  • Use pkg-config to include transitive dependencies
  • readme/ci: remove zeromq's transitive dependencies because they either aren't needed or are installed automatically if needed

@0xFFFC0000
Copy link
Collaborator

pkgconfig is already a dependency for our build. So this PR will clarify our CMake script.

@luigi1111
Copy link
Collaborator

@tobtoht please rebase

@tobtoht
Copy link
Contributor Author

tobtoht commented Dec 23, 2024

rebased

@nahuhh
Copy link

nahuhh commented Dec 23, 2024

@tobtoht :P again

@luigi1111 luigi1111 merged commit 06ab84d into monero-project:master Dec 23, 2024
2 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFFFC0000 0xFFFC0000 0xFFFC0000 approved these changes

@selsta selsta selsta approved these changes

Assignees
No one assigned
Labels
build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tobtoht @0xFFFC0000 @luigi1111 @nahuhh @selsta