closurebuilder - Allow any value for MONETATE_FLAG #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeyzito
reviewed
Apr 25, 2018
| @@ -47,7 +47,7 @@ | |||
| ^(mc\. # Must be a property of the monetate common namespace. Capture group 1. | |||
| [a-zA-Z]+\. # Must have it's own module namespace. Capture group 1. | |||
| [A-Z0-9_]+) # Must follow the constant format. Capture group 1. | |||
| =(true|false)$ # Must assign a boolean. Capture group 2. | |||
| =(.*)$ # Must assign a value. Capture group 2. | |||
There was a problem hiding this comment.
Capturing anything seems a bit "dangerous" since now there will be no true validation on the value of the feature flag. Could potentially put values in there that aren't valid for the flag being set and nothing will be spit out as an error.
There was a problem hiding this comment.
Even if we add possible values here, it can still fail because for example a variable that's a number gets overriden with a boolean or viceversa. I agree with your concern, but not sure if there's a good way to solve this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to restrict the flags to only False and True values. See https://github.com/monetate/monetate-frontend-api/pull/117/files