Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's support eslint v8 #14

Closed
sanemat opened this issue Oct 12, 2021 · 1 comment · Fixed by #20
Closed

Let's support eslint v8 #14

sanemat opened this issue Oct 12, 2021 · 1 comment · Fixed by #20

Comments

@sanemat
Copy link
Contributor

sanemat commented Oct 12, 2021

We have new eslint v8!
ESLint v8.0.0 released - ESLint - Pluggable JavaScript linter
Migrating to v8.0.0 - ESLint - Pluggable JavaScript linter

Do you have any ideas about supporting versions?

Some modules support wide range:

"eslint": "^5.16.0 || ^6.8.0 || ^7.2.0",

https://github.com/airbnb/javascript/blob/4ee732639396362c6981b1aa4730934c3baa7919/packages/eslint-config-airbnb-base/package.json#L60

In this case, we need to have below:

"@typescript-eslint/eslint-plugin": "^4.28.0 || ^5.0.0",
"@typescript-eslint/parser": "^4.28.0 || ^5.0.0",

etc.
😅

I prefer this way:

"eslint": ">=7",

"eslint": ">=7",

It may be fragile.

Do you have any ideas?

@kimromi
Copy link
Contributor

kimromi commented Oct 12, 2021

sanemat pushed a commit that referenced this issue Dec 8, 2021
sanemat pushed a commit that referenced this issue Dec 8, 2021
For preparing eslint v8, add eslint matrix(v7, v8) on ci.
refs #14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants