Deprecate buildpack now that the Python buildpack supports Poetry #75
Comments
edmorley
added a commit
to edmorley/python-poetry-buildpack
that referenced
this issue
Nov 18, 2024
This buildpack is no longer required now that the Heroku Python buildpack supports Poetry natively: - https://devcenter.heroku.com/changelog-items/3050 - heroku/heroku-buildpack-python#1682 As such, a deprecation warning has been added to both the build log and the README. The warning borrows from the implementation here (which uses colour, and also makes sure to ANSI wrap each line individually to prevent issues with streaming logs from `git push` etc): https://github.com/heroku/heroku-buildpack-python/blob/ca99c39f9e3627fff727788206f7fcc4ff064b7f/lib/output.sh#L50-L66 Closes moneymeets#75.
edmorley
added a commit
to edmorley/python-poetry-buildpack
that referenced
this issue
Nov 18, 2024
This buildpack is no longer required now that the Heroku Python buildpack supports Poetry natively: - https://devcenter.heroku.com/changelog-items/3050 - heroku/heroku-buildpack-python#1682 As such, a deprecation warning has been added to both the build log and the README. The warning borrows from the implementation here (which uses colour, and also makes sure to ANSI wrap each line individually to prevent issues with streaming logs from `git push` etc): https://github.com/heroku/heroku-buildpack-python/blob/ca99c39f9e3627fff727788206f7fcc4ff064b7f/lib/output.sh#L50-L66 Closes moneymeets#75.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi!
Poetry support has just been added to the Heroku Python buildpack:
This means using a separate buildpack (such as this one) is no longer required.
Switching from this buildpack to the built-in Python buildpack Poetry support also means that dependencies will be installed by Poetry directly, rather than the
poetry.lockfile first being exported torequirements.txtand then being installed by pip - which should result in faster builds that more closely match your local development environments.To switch over, you will need to remove this buildpack from your app configuration, since otherwise the
requirements.txtfile generated by this buildpack will take precedence overpoetry.lock. (I implemented it this way for now to ensure backwards compatibility and to allow people to migrate their apps in their own time. Though in the future the presence of multiple package manager files will be made an error to improve the UX in the case where users have accidentally ended up with several files in their repo - something that results in support tickets from time to time.)In order to raise awareness of the built-in Python buildpacks support, it would be great if this buildpack could emit a message during the build. Also, given #74 IMO it makes sense to call this a deprecation. (I'll open a PR for this now.)
The text was updated successfully, but these errors were encountered: