Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence skip feature #17

Closed
barolo opened this issue Jan 7, 2021 · 17 comments
Closed

Silence skip feature #17

barolo opened this issue Jan 7, 2021 · 17 comments
Labels
enhancement New feature or request

Comments

@barolo
Copy link

barolo commented Jan 7, 2021

Exo provides great feature called silence skip and I was amazed by its implementation in NewPipe, unfortunately it doesn't play local files. When you don't look at the video it's actually really hard to spot places where it is skipped.
Thus I would like ask for inclusion of this feature [ possibly together with speedup functionality ].

@moneytoo
Copy link
Owner

moneytoo commented Jan 7, 2021

Sounds interesting. I try that out.

Can you point out your use case / with what video does this feature makes sense? Can you share a sample?

@moneytoo
Copy link
Owner

moneytoo commented Jan 7, 2021

IMHO this is something that would be useful for podcasts instead of movies and TV shows. I would expect it to be more bound to online content. Just Player also currently doesn't have any background or music playback as it's originally intended for movies/shows.
Playback speed setting is already there (as it's provided by ExoPlayer UI).

@barolo
Copy link
Author

barolo commented Jan 8, 2021

It's great for any kind of educational content, classes etc. which many of us are in the midst of.
In one case this feature cut one of my videos from 2 hours to one, without speeding up, and it is far much pleasant to listen to.
Podcasts are pretty much covered by PocketCasts which have such feature too, it's closed source but oh well

@moneytoo moneytoo added the enhancement New feature or request label Jan 15, 2021
@AkitoFire
Copy link

I would also advocate for the addition of this silence skip feature. Like barolo mentioned, it is very useful for educational content (for example, I'm currently watching recordings of my lectures and this feature would be much more helpful than simply increasing the playback speed). Also, I think no other player offers this feature (I only know about NewPipe, but that doesn't really count), neither on Android nor on Desktop platforms. There are ways to reencode those videos but that is time-consuming and costs much more space.

@moneytoo
Copy link
Owner

You can try builds available here which have skip silence enabled (but lack UI to toggle that). See how well it works for your content.

@barolo
Copy link
Author

barolo commented Mar 28, 2021

@AkitoFire AntennaPod offers such feature, since it can play videos now, it's not intuitive since you need to add folder with videos first.

I'll check the new builds

@barolo
Copy link
Author

barolo commented Mar 28, 2021

@moneytoo That build works great!
In the future I would love to have an option to 2x/3x fastforward through silence instead skipping.

@AkitoFire
Copy link

@moneytoo Thank you! I'm not entirely sure what the difference between both builds is, but it works really well! With quieter content, the output is a garbled mess though. One possible solution for this problem would be to check for a loudness standard and adjust accordingly (specifying target LUFS, for example), but I'm not sure how to implement something like this for a normal video player.

@barolo
Copy link
Author

barolo commented May 26, 2021

@moneytoo is there a plan to include this in release builds?

@moneytoo
Copy link
Owner

@moneytoo is there a plan to include this in release builds?

Maybe in the future, but I can't promise anything. It would probably be available only after activating some advanced mode (I still need to think though that more).

@barolo
Copy link
Author

barolo commented Jun 6, 2021

@moneytoo is there a plan to include this in release builds?

Maybe in the future, but I can't promise anything. It would probably be available only after activating some advanced mode (I still need to think though that more).

Gotcha, thank you for updating the builds.

@barolo
Copy link
Author

barolo commented Jun 30, 2021

@moneytoo Could you please update the builds?

@barolo
Copy link
Author

barolo commented Sep 10, 2021

@moneytoo thank you for updates!

I have a request, could you perhaps tie playback speed to silence skip, instead of just skipping, e.g. 3x speed. It's much less jarring.
That's how the NewPipe guys do it.

moneytoo added a commit that referenced this issue Sep 11, 2021
@moneytoo
Copy link
Owner

Starting v0.59 you can enable the basic audio skip from settings. You can access settings from system App info screen (phones only) or by long pressing the gear (⚙️) icon (phones/TV).

@barolo
Copy link
Author

barolo commented Sep 12, 2021

Starting v0.59 you can enable the basic audio skip from settings. You can access settings from system App info screen (phones only) or by long pressing the gear (gear) icon (phones/TV).

Marvelous! Just updated all of my devices. Thank you.

Will you consider my request of speeding up instead of cutting for skipping?

@theScrabi
Copy link

theScrabi commented Dec 2, 2021

@moneytoo awesome 😍 but was it possible to adjust the threshold at which scipping occures? Because for my lectures to much is sciped, so understanding spoken sentences is not possible anymore.

@User087
Copy link

User087 commented Jan 15, 2024

Am I correct in thinking that this: google/ExoPlayer#6705 having been resolved should make it possible to enable the user to configure parameters of the skip-silence feature, so they can change the minimum duration of silence to be skipped, the threshold volume below which is classified as 'silence', and the duration of 'padding' on the edges of any silent portion?

@moneytoo moneytoo closed this as not planned Won't fix, can't repro, duplicate, stale Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants