Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made these changes to work with mongojs in codebases that are async/await heavy (like puppeteer tests). Eliminating callbacks also seems true to the original design statement of mongojs, to be as similar as possible to the mongodb repl. There's a reasonable amount of new test coverage and all old tests pass. However, I realize the code changes are substantial. I'm not certain if you (maintainers) want to include this feature in mongojs due to its large scope. If you do, please consider making a major version bump to alert users that some things may behave a little different.
At a minimum, the library will use a bit more memory due to creating Promise objects whenever an API is called without a callback in existing code, as this absence of a callback is what signals the creation of a Promise now. This should be harmless most of the time but it's hard to know how it might interact with what's out there. Cheers, and thanks for a great little mongodb lib over the years!