Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: CHARTS-8818 add rendering spec documentation #86

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

mongo-J
Copy link
Collaborator

@mongo-J mongo-J commented Aug 21, 2023

Summary

This PR adds:

  • Documentation for Embedded Chart Rendering Specification
  • Link to the Rendering spec doc from the README file

@mongo-J mongo-J added the documentation Improvements or additions to documentation label Aug 21, 2023
@mongo-J mongo-J self-assigned this Aug 21, 2023
Copy link
Collaborator

@khanguslee khanguslee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @mongo-J and @kristinamongo on the documentation! Just some minor mistakes to be fixed and then we can merge it in.

docs/rendering-spec.md Outdated Show resolved Hide resolved
docs/rendering-spec.md Outdated Show resolved Hide resolved
docs/rendering-spec.md Outdated Show resolved Hide resolved
docs/rendering-spec.md Outdated Show resolved Hide resolved
docs/rendering-spec.md Outdated Show resolved Hide resolved
docs/rendering-spec.md Outdated Show resolved Hide resolved
Copy link

@lilyh4 lilyh4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These docs look great! LGTM with a couple of typos and grammar nits.

docs/rendering-spec.md Outdated Show resolved Hide resolved
docs/rendering-spec.md Outdated Show resolved Hide resolved
docs/rendering-spec.md Outdated Show resolved Hide resolved
docs/rendering-spec.md Outdated Show resolved Hide resolved
docs/rendering-spec.md Outdated Show resolved Hide resolved
docs/rendering-spec.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@khanguslee khanguslee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥳

@mongo-J mongo-J merged commit 3e21565 into master Aug 22, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants