This repository has been archived by the owner on Feb 4, 2022. It is now read-only.
Fix Automattic/mongoose#3481; flush callbacks on error #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Christian,
Re: Automattic/mongoose#3481. This issue is hard to repro consistently and really only happens if you get very unlucky, which is why I didn't include a test (figured you might have some ideas on that front). The general idea is that if you're connected to a standalone mongod and happen to have a write going when the mongod dies, the server will swallow the connection pool error, try to reconnect, and leave a callback hanging. Here's the debug output:
Once this happens and the mongod comes back, the pool reconnects just fine, but the callback still hangs. Let me know if you need more info or have any suggestions.