feat(java-shell): don't convert object from Java to JS and back if re…

…sults are returned directly to user (#1077)
mongodb-js · Aug 24, 2021 · b5ed69e · b5ed69e
1 parent 90d2a88
commit b5ed69e
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 3 deletions.
diff --git a/packages/java-shell/src/main/kotlin/com/mongodb/mongosh/result/Cursor.kt b/packages/java-shell/src/main/kotlin/com/mongodb/mongosh/result/Cursor.kt
@@ -1,11 +1,19 @@
 package com.mongodb.mongosh.result
 
 import com.mongodb.mongosh.MongoShellConverter
+import com.mongodb.mongosh.get
+import com.mongodb.mongosh.set
 import org.graalvm.polyglot.Value
 
 open class Cursor<out T> internal constructor(protected var cursor: Value?, private var converter: MongoShellConverter?) : Iterator<T> {
     private var currentIterationResult: List<T>? = null
 
+    init {
+        if (cursor?.get("_transform")?.isNull == true) {
+            cursor?.get("_cursor")?.set("resultsUsedInScript", false)
+        }
+    }
+
     fun _asPrintable(): String = ArrayResult(currentIterationResult ?: it())._asPrintable()
 
     private fun it(): List<T> {

diff --git a/packages/java-shell/src/main/kotlin/com/mongodb/mongosh/service/Cursor.kt b/packages/java-shell/src/main/kotlin/com/mongodb/mongosh/service/Cursor.kt
@@ -15,6 +15,10 @@ internal class Cursor(private var helper: BaseMongoIterableHelper<*>, private va
     @HostAccess.Export
     var closed = false
 
+    @JvmField
+    @HostAccess.Export
+    var resultsUsedInScript = true
+
     private fun getOrCreateIterator(): MongoCursor<out Any?> {
         var it = iterator
         if (it == null) {
@@ -172,13 +176,13 @@ internal class Cursor(private var helper: BaseMongoIterableHelper<*>, private va
     @HostAccess.Export
     override fun next(): Any? {
         val value = getOrCreateIterator().next()
-        return converter.toJs(value)
+        return if (resultsUsedInScript) converter.toJs(value) else value
     }
 
     @HostAccess.Export
     override fun tryNext(): Any? {
         val value = getOrCreateIterator().tryNext()
-        return converter.toJs(value)
+        return if (resultsUsedInScript) converter.toJs(value) else value
     }
 
     @HostAccess.Export

diff --git a/packages/java-shell/src/test/resources/collection/insertOne.expected.txt b/packages/java-shell/src/test/resources/collection/insertOne.expected.txt
@@ -1,3 +1,3 @@
 { "acknowledged": true, "insertedId": "UNKNOWN" }
 true
-[ { "_id": <ObjectID>, "a": 1, "objectId": <ObjectID>, "maxKey": {"$maxKey": 1}, "minKey": {"$minKey": 1}, "binData": {"$binary": {"base64": "MTIzNA==", "subType": "10"}}, "date": {"$date": {"$numberLong": "1355875200000"}}, "isoDate": {"$date": {"$numberLong": "1355875200000"}}, "numberInt": 24, "timestamp": {"$timestamp": {"t": 100, "i": 0}}, "undefined": null, "null": null, "uuid": <UUID> } ]
+[ { "_id": <ObjectID>, "a": 1, "objectId": <ObjectID>, "maxKey": {"$maxKey": 1}, "minKey": {"$minKey": 1}, "binData": {"$binary": {"base64": "MTIzNA==", "subType": "10"}}, "date": {"$date": {"$numberLong": "1355875200000"}}, "isoDate": {"$date": {"$numberLong": "1355875200000"}}, "numberInt": 24, "timestamp": Timestamp{value=429496729600, seconds=100, inc=0}, "undefined": null, "null": null, "uuid": <UUID> } ]