fixup: unconditionally call fetchConnections() on startup (but do not…

… always wait for result)
mongodb-js · Apr 24, 2024 · f2842ee · f2842ee
1 parent 40d6d23
commit f2842ee
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 21 deletions.
diff --git a/packages/cli-repl/src/cli-repl.spec.ts b/packages/cli-repl/src/cli-repl.spec.ts
@@ -1519,25 +1519,6 @@ describe('CliRepl', function () {
             cliRepl,
             await testServer.connectionString()
           );
-          expect(
-            requests
-              .flatMap((req) =>
-                JSON.parse(req.body).batch.map((entry) => entry.event)
-              )
-              .sort()
-              .filter(Boolean)
-          ).to.deep.equal(['API Call', 'Script Evaluated', 'Startup Time']);
-          expect(totalEventsTracked).to.equal(4);
-        });
-
-        it('includes an additional event for connection info if not in quiet mode', async function () {
-          cliReplOptions.shellCliOptions.eval = ['db.hello()'];
-          cliReplOptions.shellCliOptions.quiet = false;
-          cliRepl = new CliRepl(cliReplOptions);
-          await startWithExpectedImmediateExit(
-            cliRepl,
-            await testServer.connectionString()
-          );
           expect(
             requests
               .flatMap((req) =>
@@ -1564,7 +1545,7 @@ describe('CliRepl', function () {
             cliRepl,
             await testServer.connectionString()
           );
-          expect(totalEventsTracked).to.equal(6);
+          expect(totalEventsTracked).to.equal(7);
 
           const apiEvents = requests
             .map((req) =>

diff --git a/packages/cli-repl/src/mongosh-repl.ts b/packages/cli-repl/src/mongosh-repl.ts
@@ -199,7 +199,10 @@ class MongoshNodeRepl implements EvaluationListener {
     // not-quiet mode -> We'll need it for the greeting message (and need it now)
     // REPL mode -> We'll want it for fast autocomplete (and need it soon-ish, but not now)
     instanceState.setPreFetchCollectionAndDatabaseNames(!usePlainVMContext);
-    if (!this.shellCliOptions.quiet || !usePlainVMContext) {
+    // `if` commented out because we currently still want the connection info for
+    // logging/telemetry but we may want to revisit that in the future:
+    // if (!this.shellCliOptions.quiet || !usePlainVMContext)
+    {
       const connectionInfoPromise = instanceState.fetchConnectionInfo();
       connectionInfoPromise.catch(() => {
         // Ignore potential unhandled rejection warning