feat(browser-runtime-core): remove preprocessing MONGOSH-931 #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the preprocessing inside the browser package, as it mismatches with the preprocessing we do inside the async rewriter. Since none of the steps taken here were actually browser-specific in any way, we should keep further adjustments to the async-rewriter package itself. Some of the existing tests for the preprocessor were ported over to be applied directly to the `OpenContextRuntime` class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the preprocessing inside the browser package, as it mismatches
with the preprocessing we do inside the async rewriter. Since none
of the steps taken here were actually browser-specific in any way,
we should keep further adjustments to the async-rewriter package
itself.
Some of the existing tests for the preprocessor were ported over to
be applied directly to the
OpenContextRuntimeclass.