feat(shell-api): Support boolean "true" with currentOp MONGOSH-1131 #1219
Conversation
packages/shell-api/src/database.ts
Outdated
| if (opts === true) { | ||
| opts = { $all: true }; |
There was a problem hiding this comment.
I think you want something like
| if (opts === true) { | |
| opts = { $all: true }; | |
| if (typeof opts === 'boolean') { | |
| opts = { $all: opts }; |
even though it probably won’t be used with false as an argument much?
There was a problem hiding this comment.
By documentation it seems that only true is an accepted value. It's not clear what happens using false as value.
There was a problem hiding this comment.
I mean, passing false is the same as passing no argument, but the docs do explicitly say “Can pass either a boolean or a document”.
(The legacy shell just ignores the argument entirely if it is false: https://github.com/mongodb/mongo/blob/8c85963c5e8e6cec0ba996de80e3cc7aa5a6b39d/src/mongo/shell/db.js#L835)
There was a problem hiding this comment.
ok makes sense. Added this case and related test case.
There was a problem hiding this comment.
I think you might have forgotten to git push? :)
There was a problem hiding this comment.
Yeah, exactly, now the ocde is updated
No description provided.