Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for show freeMonitoring and friends MONGOSH-1185 #1289

Merged
merged 8 commits into from
May 31, 2022

Conversation

addaleax
Copy link
Contributor

Add support for the following and run them at startup:

  • show startupWarnings
  • show freeMonitoring
  • show automationNotices

This matches the behavior of these calls in the legacy shell.

The startupWarnings code was extracted from its current existing
location in the cli-repl package, with the log entry parsing
helper being moved as well.

Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will try out a bit tomorrow, looks good, nice tests too. Two smaller questions

Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, left a couple small comments, fine to merge as is, the comments are just some light questions/thoughts.

packages/shell-api/src/helpers.ts Show resolved Hide resolved
testing/integration-testing-hooks.ts Outdated Show resolved Hide resolved
addaleax added 5 commits May 25, 2022 17:49
Add support for the following and run them at startup:
- `show startupWarnings`
- `show freeMonitoring`
- `show automationNotices`

This matches the behavior of these calls in the legacy shell.

The `startupWarnings` code was extracted from its current existing
location in the `cli-repl` package, with the log entry parsing
helper being moved as well.
@addaleax addaleax merged commit 9e640a9 into main May 31, 2022
@addaleax addaleax deleted the 1185-dev branch May 31, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants