-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for show freeMonitoring
and friends MONGOSH-1185
#1289
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will try out a bit tomorrow, looks good, nice tests too. Two smaller questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, left a couple small comments, fine to merge as is, the comments are just some light questions/thoughts.
packages/browser-repl/src/components/types/show-banner-result-output.tsx
Show resolved
Hide resolved
Add support for the following and run them at startup: - `show startupWarnings` - `show freeMonitoring` - `show automationNotices` This matches the behavior of these calls in the legacy shell. The `startupWarnings` code was extracted from its current existing location in the `cli-repl` package, with the log entry parsing helper being moved as well.
Add support for the following and run them at startup:
show startupWarnings
show freeMonitoring
show automationNotices
This matches the behavior of these calls in the legacy shell.
The
startupWarnings
code was extracted from its current existinglocation in the
cli-repl
package, with the log entry parsinghelper being moved as well.