fix(shell-api): allow pipeline-style bulk update operations MONGOSH-1281 #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix cloning of the update documents to allow arrays as well as objects, so that users can use aggregation pipelines for bulk updates. Also, remove the buggy `hint` and `arrayFilters` implementation that was storing extra properties in the wrong place on the outgoing documents, and instead fully rely on driver helpers to implement these.
lerouxb
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cloning of the update documents to allow arrays as well as objects, so that users can use aggregation pipelines for bulk updates.
Also, remove the buggy
hintandarrayFiltersimplementation that was storing extra properties in the wrong place on the outgoing documents, and instead fully rely on driver helpers to implement these.