feat(shell-api): use $currentOp agg. stage for db.currentOp #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himanshusinghs
commented
Jan 30, 2023
himanshusinghs
commented
Jan 30, 2023
himanshusinghs
commented
Jan 30, 2023
himanshusinghs
commented
Jan 30, 2023
addaleax
reviewed
Jan 30, 2023
Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>
Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>
Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>
addaleax
approved these changes
Jan 30, 2023
- currentOp does not use runCommandWithCheck any more and hence pushed to exceptions list
addaleax
approved these changes
Feb 1, 2023
himanshusinghs
changed the title
himanshusinghs
deleted the
MONGOSH-1157-currentOp-moved-to-aggregation
branch
Merged
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the implementation of
db.currentOpto make use of$currentOpaggregation stage instead of the command form. There is no change in the output format of the helper. The old arguments are also left intact and are appropriately mapped to relevant options for$currentOpstage (reference taken from the old shell)Closes: