fix(cli-repl): throw error when changing telemetry setting while forceDisableTelemetry: true MONGOSH-1762

[addaleax]

No description provided.

[Ghostbird]

Ah, so this is why our docker containers were failing. This was the startup command of our docker container.

bash -mc "mongod --replSet rs0 & sleep 3; mongosh --eval 'disableTelemetry(); rs.initiate()'; fg

This used to work fine, but now crashed, and the replica set was never initialised. The weird thing is that apparently forceDisableTelemetry is set to true, but I have no clue why it's set to true.

It doesn't seem to be done by the docker image, nor by this repo.

I think this should have only thrown when trying to change the telemetry setting. It shouldn't throw when disabling it.

UPDATE:

Found it! It's getter logic that forces telemetry to be disabled for containerised non-interactive usage specifically.

mongosh/packages/cli-repl/src/cli-repl.ts

Line 228 in 6d9162c

(this.isContainerizedEnvironment && !this.mongoshRepl.isInteractive)

Would be nice if this were documented. There it says that telemetry is automatically enabled. Apparently that's not always true.

Also it would be nice that this new feature is documented there. Currently there's no mention that enableTelemetry() and disableTelemetry() may throw.

[addaleax]

@Ghostbird You are completely right – thanks for bringing this up! #1966

[addaleax]

@Ghostbird And sorry for the delay, but just to present you with an update, we just released mongosh 2.2.6 with the fix – thanks again for bringing this up!

[Ghostbird]

Thanks for the fix!