Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: report hostname for atlas COMPASS-8093 #2113

Merged
merged 22 commits into from
Aug 14, 2024

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Jul 31, 2024

For every detected Atlas cluster track the resolved hostname without the port when connecting.

@alenakhineika alenakhineika marked this pull request as ready for review August 1, 2024 16:06
@alenakhineika alenakhineika requested a review from addaleax August 1, 2024 16:06
packages/service-provider-core/src/connect-info.ts Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
packages/types/src/index.ts Show resolved Hide resolved
packages/types/src/index.ts Outdated Show resolved Hide resolved
packages/shell-api/src/shell-instance-state.ts Outdated Show resolved Hide resolved
packages/service-provider-core/src/connect-info.ts Outdated Show resolved Hide resolved
packages/logging/src/setup-logger-and-telemetry.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This looks pretty good already 🙂

packages/service-provider-core/src/connect-info.ts Outdated Show resolved Hide resolved
packages/service-provider-core/src/connect-info.ts Outdated Show resolved Hide resolved
packages/logging/src/setup-logger-and-telemetry.spec.ts Outdated Show resolved Hide resolved
packages/logging/src/setup-logger-and-telemetry.spec.ts Outdated Show resolved Hide resolved
packages/logging/src/setup-logger-and-telemetry.spec.ts Outdated Show resolved Hide resolved
packages/logging/src/setup-logger-and-telemetry.spec.ts Outdated Show resolved Hide resolved
@alenakhineika alenakhineika merged commit 98a0619 into main Aug 14, 2024
68 of 71 checks passed
@alenakhineika alenakhineika deleted the COMPASS-8093-report-hostname-for-atlas branch August 14, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants